Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ZIF_ABAPGIT_CI_REPO_PROVIDER for https://dotabap.org/ #76

Open
gregorwolf opened this issue May 4, 2020 · 1 comment
Open

Comments

@gregorwolf
Copy link
Collaborator

in the SAP Community Q&A post SAP sponsored check of OpenSource ABAP Projects with Code Vulnerability Analyzer we've born the idea to get an automated security check for all projects listed in https://dotabap.org/. I've just checked how abapGit CI does currently get the projects in the Organization abapGit-tests. This is implemented in the class ZCL_ABAPGIT_CI_TEST_REPOS which implements the interface ZIF_ABAPGIT_CI_REPO_PROVIDER. And this class is then used in the report ZABAPGIT_CI to provide the list of repositories to zcl_abapgit_ci_controller.

Should I simply go ahead and do the following:

  • implement a class ZCL_ABAPGIT_CI_DOTABAP_REPOS that reads the repositories from https://raw.githubusercontent.com/dotabap/dotabap-list/master/list.json and returns the repositories as needed.
  • Adjust the report ZABAPGIT_CI to provide a select option where the implementation classes of ZIF_ABAPGIT_CI_REPO_PROVIDER can be provided. Fill that select option by default with ZCL_ABAPGIT_CI_TEST_REPOS so the current users of ZABAPGIT_CI don't see any difference.
  • Use the input from the select option run zcl_abapgit_ci_controller multiple times if needed.

?

@christianguenter2
Copy link
Member

Sounds good to me. Feel free to go ahead.

larshp added a commit that referenced this issue Jun 18, 2020
* Correct name for ZABAPGIT_CI_JOB_SCHEDULER

* Refactoring for #76

Co-Contibutor S�ren Schlegel

* Correct pretty print for #76

* abaplint corrections for #76

* add description, ZIF_ABAPGIT_CI_REPO_PROVIDER

* add description, ZIF_ABAPGIT_CI_VIEW

* add description, ZIF_ABAPGIT_CI_DEFINITIONS

* abaplint: add deps

* allow public readonly attrs

* "commented_code": true

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants