Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistent symbol naming #14

Open
sakulstra opened this issue Mar 3, 2021 · 0 comments
Open

consistent symbol naming #14

sakulstra opened this issue Mar 3, 2021 · 0 comments

Comments

@sakulstra
Copy link
Contributor

Current state of symbol naming:

Subgraph
  • mainnet we return aToken.symbol.slice(1) -> e.g. aUSDC on proto, but aAamUSDC on amm
UI helper contracts
  • always return aToken.symbol

We can surely work around that, but it's weird. I'd rather have it consistent.
sakulstra added a commit that referenced this issue Mar 15, 2021
@sakulstra
feat: consistent naming of tokens
4f00c99 
- closes #14
@sakulstra sakulstra mentioned this issue Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove slice aave/protocol-subgraphs
1 participant
@sakulstra