Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lease_seconds should be optional during unsubscribing #14

Open
marten-de-vries opened this issue Aug 26, 2017 · 0 comments
Open

lease_seconds should be optional during unsubscribing #14

marten-de-vries opened this issue Aug 26, 2017 · 0 comments

Comments

@marten-de-vries
Copy link

While testing my implementation with https://websub.rocks/hub/104, after clicking the 'Unsubscribe' button (using a public hub) while 'Waiting for unsubscription to be confirmed' I get the following error:

Error!

The verification request was missing the hub.lease_seconds parameter

The spec has the following to say about lease_seconds (5.3 Hub Verifies Intent of the Subscriber):

hub.lease_seconds
REQUIRED/OPTIONAL. The hub-determined number of seconds that the subscription will stay active before expiring, measured from the time the verification request was made from the hub to the subscriber. Hubs MUST supply this parameter for subscription requests. This parameter MAY be present for unsubscribe requests and MUST be ignored by subscribers during unsubscription.

In short, I think the test suite, acting as a subscriber here, violates the last MUST.

(Moved from w3c/websub#122)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant