Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set builder only if null #328

Open
Marco-Sulla opened this issue May 1, 2019 · 1 comment
Open

set builder only if null #328

Marco-Sulla opened this issue May 1, 2019 · 1 comment

Comments

@Marco-Sulla
Copy link
Contributor

In Query.java, under newResultSetHandlerFactory(), we have

    if(builder==null) builder=new DefaultResultSetHandlerFactoryBuilder();
    builder.setAutoDeriveColumnNames(this.autoDeriveColumnNames);
    builder.setCaseSensitive(this.caseSensitive);
    builder.setColumnMappings(this.getColumnMappings());
    builder.setQuirks(quirks);
    builder.throwOnMappingError(this.throwOnMappingFailure);

I think it should be

if(builder==null)  {
    builder=new DefaultResultSetHandlerFactoryBuilder();
    builder.setAutoDeriveColumnNames(this.autoDeriveColumnNames);
    builder.setCaseSensitive(this.caseSensitive);
    builder.setColumnMappings(this.getColumnMappings());
    builder.setQuirks(quirks);
    builder.throwOnMappingError(this.throwOnMappingFailure);
}

so you can pass a completely customized builder.

@Marco-Sulla
Copy link
Contributor Author

Vedi pull #330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant