Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/rework test keyword to keep test data hidden #138

Open
Tracked by #54
bfhealy opened this issue Oct 25, 2022 · 0 comments
Open
Tracked by #54

Rename/rework test keyword to keep test data hidden #138

bfhealy opened this issue Oct 25, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@bfhealy
Copy link
Collaborator

bfhealy commented Oct 25, 2022

The test kwarg in the training code (e.g. below) is misleading - when it is False (default), statistics on the test set will be computed and logged. It is good practice to run the intermediate iterations of our training without looking at the test scores. Changing this keyword to something like 'evaluate_test' and reworking the boolean logic could hide the test data from us until we are ready to review and report it.

https://github.com/ZwickyTransientFacility/scope/blob/ac22f211a188eb1736e35eb9c6c552a902735fb5/scope.py#L658

@bfhealy bfhealy added the enhancement New feature or request label Oct 25, 2022
@bfhealy bfhealy mentioned this issue Oct 25, 2022
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant