Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check ProGuard rules and update installation guide for 0.16.0.1 and master's head. #412

Open
koral-- opened this issue Jun 8, 2020 · 1 comment
Assignees

Comments

@koral--
Copy link

koral-- commented Jun 8, 2020

Data binding enabling has been removed from wiki:
https://github.com/ZieIony/Carbon/wiki/Installation/_compare/91c996c21d10d6a392ececfe7f27f94b50d2f699...533c5ddd5f0f04b11d91228ca8e8ac7f00fbcc6d

However, related proguard rules are still listed:

-dontwarn android.databinding.**
-keep class android.databinding.** { *; }

Is it somehow intended? Or they are redundant?
BTW why don't embed consumer proguard rules?

@ZieIony
Copy link
Owner

ZieIony commented Jun 8, 2020

I simply forgot that these rules were there. I rarely build my side projects in release versions, so I don't pay too much attention to that, unless someone points that out. Data binding was the only thing that didn't work in the history of Carbon because of ProGuard.

I updated these instructions to be up-to-date with what's now on master branch. Carbon currently uses view binding internally, so data binding setup is not needed with that version. I didn't check if this generator needs ProGuard rules though.

@ZieIony ZieIony self-assigned this Jun 8, 2020
@ZieIony ZieIony changed the title Proguard rules for 0.16.0.1 Check ProGuard rules and update installation guide for 0.16.0.1 and master's head. Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants