Unzipping a 0 compression ZIP which contains another 0 compression ZIP results in the stream being closed prematurely

[joshuakitchen]

I am currently using unzipper to unzip a ZIP file which has been created using 0 compression and also contains another ZIP which contains 0 compression.

Due to unzipper looking for the EOF (0x08074b50), it finds this prematurely due to the internal ZIP and closes the stream early.

Recreation code using Archiver:

'use strict'

const archiver = require('archiver')
const fs = require('fs')
const unzipper = require('unzipper')

const createArchive = function createArchive() {
  return new Promise(function _createArchivePromise (resolve, reject) {
    try {
      const fileReadStream = fs.createReadStream('./image.png')
      const zipWriteStream = fs.createWriteStream('./test.zip')

      const archive = archiver('zip', {
        zlib: {
          level: 0
        }
      })

      archive.pipe(zipWriteStream)

      archive.append(fileReadStream, { name: 'image.png' })
      archive.append(fs.createReadStream('internal.zip'), { name: 'internal.zip' })
      archive.append(fs.createReadStream('internal.zip'), { name: 'internal (1).zip' })
      archive.append(fs.createReadStream('internal.zip'), { name: 'internal (2).zip' })
      archive.append(fs.createReadStream('internal.zip'), { name: 'internal (3).zip' })
      archive.append(fs.createReadStream('internal.zip'), { name: 'internal (4).zip' })
      archive.append(fs.createReadStream('internal.zip'), { name: 'internal (5).zip' })
      archive.finalize()

      archive.on('finish', function () {
        resolve()
      })
    } catch (err) {
      reject(err)
    }
  })
}

const main = async function main () {
  await createArchive()

  const readStream = fs.createReadStream('./test.zip')
  readStream.pipe(unzipper.Parse({
    verbose: true
  })).on('error', function _onError(err) {
    console.error(err)
  }).on('entry', function _onEntry (entry) {
    const writeStream = fs.createWriteStream(`./unzipped/${entry.path}`)
    writeStream.on('error', function _onError(err) {
      console.error(err)
    })
    entry.pipe(writeStream)
  }).on('finish', function _onFinish () {
    console.log('done')
    // fs.promises.unlink('./test.zip').catch(console.error)
  })
}

main().catch(console.error)