feat(rotable): add metatable support to rotable #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires lua5.4 |
So we can use the userdata uservalue for other purpose Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
XuNeo
force-pushed
the
rotable-metatable
branch
2 times, most recently
from
48c08f0
to
6b74d21
Compare
Use userdata's uservalue as a place to store metatable. Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rodata's meta table is already used to fake the normal table operation, we use userdata uservalue[2] to store an optional table as meta table. It's further searched when no match found in rodata's __index method.
Fix bug in rotable_newidx.