Calls to the YM Generate and Engine_Timer_Expired are out of sync

[Yazwh0]

The call to engine_timer_expired is in update_clocks(), but as that is called with the number of samples before the stepped call to m_chip.generate, the results will probably not match hardware as apparently one timer is tied to Key Down.

		void update_clocks(int cycles) {
			m_busy_timer = std::max(0, m_busy_timer - (64 * cycles));
			for (int i = 0; i < 2; ++i) {
				if (m_timers[i] > 0) {
					m_timers[i] = std::max(0, m_timers[i] - (64 * cycles));
					if (m_timers[i] <= 0) {
						m_engine->engine_timer_expired(i);
					}
				}
			}	
		}
...
		void generate(int16_t* output, uint32_t numsamples) {
			int s = 0;
			int ls, rs;
			update_clocks(numsamples);
			for (uint32_t i = 0; i < numsamples; i++) {
				m_chip.generate(&opm_out);
				ls = opm_out.data[0];
				rs = opm_out.data[1];
				if (ls < -32768) ls = -32768;
				if (ls > 32767) ls = 32767;
				if (rs < -32768) rs = -32768;
				if (rs > 32767) rs = 32767;
				output[s++] = ls;
				output[s++] = rs;
			}
		}

[mooinglemur]

Do you have a suggestion for how to change it?

[Yazwh0]

Best guess is call update_clock(1) in the loop within generate.

I don't know enough about the YM chip to really opine though.