-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize inference UDP and share with GISAT #171
Comments
@jdries , how should we proceed here? Basically the UDP should be a wrapper around the generate_map function --> https://github.com/WorldCereal/worldcereal-classification/blob/main/src/worldcereal/job.py#L69 Does the current UDP already allow to pass the different input parameters to generate_map? Should we ask the data engineering team to update the UDP? Guess would be more efficient that way, instead of me trying to figure it out... |
@jdegerickx yes indeed, next step is to get this improved/merged: It's also possible to update the current udp definition as a kind of quick fix, but prefer to also get the code right. |
@HansVRP, @VincentVerelst , any update on this one? |
WIll be planned in this sprint |
@jdegerickx, so this issue now refers to the crop extent UDP, not the crop type UDP? |
@VincentVerelst, would be good to have two separate worldcereal inference UDP's:
I suggest we just start with the default crop extent mapping and later on create a separate issue for the custom model inference, if that's ok? Additional notes:
|
|
@jdegerickx , ok to close this issue and later open a new one for custom crop type? |
I still would like to test the UDP myself first. |
No description provided.
The text was updated successfully, but these errors were encountered: