Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize inference UDP and share with GISAT #171

Open
jdegerickx opened this issue Oct 2, 2024 · 10 comments
Open

Finalize inference UDP and share with GISAT #171

jdegerickx opened this issue Oct 2, 2024 · 10 comments
Assignees

Comments

@jdegerickx
Copy link
Contributor

No description provided.

@jdegerickx jdegerickx self-assigned this Oct 2, 2024
@jdegerickx
Copy link
Contributor Author

@jdries , how should we proceed here?
Would be good to have an inference UDP both for GISAT and Maps4GPP project to allow people to work on user interfaces...

Basically the UDP should be a wrapper around the generate_map function --> https://github.com/WorldCereal/worldcereal-classification/blob/main/src/worldcereal/job.py#L69

Does the current UDP already allow to pass the different input parameters to generate_map?

Should we ask the data engineering team to update the UDP? Guess would be more efficient that way, instead of me trying to figure it out...

@jdries
Copy link
Contributor

jdries commented Oct 18, 2024

@jdegerickx yes indeed, next step is to get this improved/merged:
Open-EO/openeo-gfmap#144
I asked @HansVRP to have a look and take over if possible.

It's also possible to update the current udp definition as a kind of quick fix, but prefer to also get the code right.

@jdegerickx
Copy link
Contributor Author

jdegerickx commented Oct 18, 2024

thanks @jdries !
@HansVRP , the inference pipeline should be stable for a while now, so best to get this UDP ready asap so our partners can start integration.
Would be happy to test once we have a first version ready!

@jdegerickx
Copy link
Contributor Author

@HansVRP, @VincentVerelst , any update on this one?

@HansVRP
Copy link
Contributor

HansVRP commented Nov 12, 2024

WIll be planned in this sprint

@VincentVerelst
Copy link
Contributor

@jdegerickx, so this issue now refers to the crop extent UDP, not the crop type UDP?

@jdegerickx
Copy link
Contributor Author

@VincentVerelst, would be good to have two separate worldcereal inference UDP's:

  1. https://github.com/WorldCereal/worldcereal-classification/blob/main/notebooks/worldcereal_v1_demo_custom_croptype_extended.ipynb
  2. https://github.com/WorldCereal/worldcereal-classification/blob/main/notebooks/worldcereal_v1_demo_custom_cropland.ipynb

I suggest we just start with the default crop extent mapping and later on create a separate issue for the custom model inference, if that's ok?

Additional notes:

  • the notebooks show how to retrieve the worldcereal crop calendars for a given bounding box. This should not be part of the UDP.
  • all notebooks also contain additional steps to properly visualize the resulting products after applying the "generate_map" function. These steps should obviously not be part of the UDP.

@VincentVerelst
Copy link
Contributor

VincentVerelst commented Nov 19, 2024

  • Worldcereal crop extent UDP
  • Worldcereal crop type UDP

@VincentVerelst
Copy link
Contributor

@jdegerickx , ok to close this issue and later open a new one for custom crop type?

@jdegerickx
Copy link
Contributor Author

I still would like to test the UDP myself first.
Then we would need a discussion on how to deal with postprocessing parameters in the UDP.
And only then move to crop type inference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants