-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project proposal and IP for license migration #5158
base: main
Are you sure you want to change the base?
Conversation
Full-stack documentation: https://docs.openverse.org/_preview/5158 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. New files ➕:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great write-up, @dhruvkb. Thanks for doing this extensive research and sharing your findings. My impression is that the overall process is correct. I just left some comments to clarify the licenses a bit more and I don't expect there to be any blocker once those little details are added.
documentation/projects/proposals/relicensing/20241028-implementation_plan_relicensing.md
Show resolved
Hide resolved
- Applications | ||
- API | ||
- Frontend | ||
- DAGs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do "DAGs" include the catalog (Airflow) and the indexer workers? I'm thinking about whether they should go under application 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We classified the DAGs (i.e. our pipelines for fetching media from providers) separately from apps for two reasons:
- They are highly specific to us, and not very generalised so they don't fall under the definition of a library.
- Their primary use for folks other than us is reference implementation of an API, in which the GPL license covers it adequately.
I don't think we discussed what the ingestion server and indexer worker would be classified as, but I feel like the ingestion server falling under the default GPL license would be fair.
Applications are licensed as AGPL because they're primarily used by end-users over a network, which does not count as distribution and thus not covered by the GPL.
documentation/projects/proposals/relicensing/20241028-implementation_plan_relicensing.md
Outdated
Show resolved
Hide resolved
- `api/conf/settings/spectacular.py` | ||
- `catalog/tests/factories/github/pull.json` | ||
|
||
## Communications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the Make blog be the medium for these announcements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a Make blog announcement is necessary, where we should clarify that this change does not affect the consumers of the API and users of the frontend in any way. Once the license change is done, we can also push it via marketing channels and social media, as it is good to have more consolidation and alignment within the WP ecosystem.
documentation/projects/proposals/relicensing/20241028-implementation_plan_relicensing.md
Show resolved
Hide resolved
Co-authored-by: Krystle Salazar <krystle.salazar@ciens.ucv.ve>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for complementing the licenses. LGTM!
documentation/projects/proposals/relicensing/20241028-implementation_plan_relicensing.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>
Description
This PR adds the project proposal and implementation plan for the license changes.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin