Skip to content
This repository has been archived by the owner on Feb 14, 2022. It is now read-only.

When you spam horn button, app will crash #31

Closed
ggoraa opened this issue May 2, 2021 · 4 comments
Closed

When you spam horn button, app will crash #31

ggoraa opened this issue May 2, 2021 · 4 comments
Assignees
Labels
bug Something isn't working comm no activity
Milestone

Comments

@ggoraa
Copy link
Contributor

ggoraa commented May 2, 2021

Fix is also easy, we need to migrate from server action execution to normal BLE request action execution. But the server endpoint to horn trigger will still be there, bc why not, it wont break anything

@ggoraa ggoraa added the bug Something isn't working label May 2, 2021
@ggoraa ggoraa added this to the 1.0.0 Stable milestone May 2, 2021
@ggoraa ggoraa self-assigned this May 2, 2021
@ggoraa ggoraa added the comm label May 3, 2021
@ggoraa ggoraa removed this from the 1.0.0 Stable milestone May 4, 2021
@ggoraa
Copy link
Contributor Author

ggoraa commented May 29, 2021

For now, when the app will be in 2.x.x release phase, it will have a simple solution for this: just limit count clicks of the button in a row. When I update WheelLog code, this app will go into 3.x.x release phase, and I will remove this feature, and implement the one I explained first time

@ggoraa ggoraa pinned this issue May 29, 2021
@github-actions
Copy link

This issue had no activity in a while. Please check it!

@ggoraa
Copy link
Contributor Author

ggoraa commented Jul 31, 2021

This feature will be implemented in 3.0.0, I am currently working on it, but it will be only available with latest versions of WheelLog and it's Garmin companion

@github-actions
Copy link

This issue had no activity in a while. Please check it!

@github-actions github-actions bot closed this as completed Oct 8, 2021
@ggoraa ggoraa reopened this Oct 8, 2021
@ggoraa ggoraa reopened this Oct 16, 2021
@ggoraa ggoraa added this to the 3.0.0 Release milestone Oct 22, 2021
@ggoraa ggoraa reopened this Oct 30, 2021
@github-actions github-actions bot closed this as completed Nov 7, 2021
@ggoraa ggoraa reopened this Nov 10, 2021
@ggoraa ggoraa reopened this Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working comm no activity
Projects
None yet
Development

No branches or pull requests

1 participant