Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the installtion and check is it work on each Linux ex. Ubuntu, Arch, Void, Stand-alone wm's #37

Open
Waishnav opened this issue Oct 20, 2022 · 5 comments
Open

Test the installtion and check is it work on each Linux ex. Ubuntu, Arch, Void, Stand-alone wm's #37

Waishnav opened this issue Oct 20, 2022 · 5 comments
Assignees
@dishantzaveri
Labels
good first issue Good for newcomers low-code non-code

Comments

@Waishnav
Copy link
Owner

No description provided.

@dishantzaveri
Copy link

@Waishnav please assign it to me.

@Waishnav
Copy link
Owner Author

You can work on this issue.

@Waishnav
Copy link
Owner Author

Waishnav commented Nov 2, 2022

@dishantzaveri
Have you prepared the docs so that we can understand the installation issues/bugs for all Linux distros?
Even if you have tried on arch or void, ubuntu, or any of the Linux distros given above, make a markdown so that

@nboss3
Copy link
Contributor

nboss3 commented Nov 11, 2024

@Waishnav Tested Watcher on Linux Mint running mate-terminal, installation is successful but currently throws OSError when command is run. In order for Watcher to run on Ubuntu systems, the /home/+os.getlogin() calls in the source scripts need to be replaced with os.environ['HOME'] I will see if I can get neovim detection working also.

@Waishnav
Copy link
Owner Author

Waishnav commented Nov 11, 2024 •
edited
Loading

Thanks for sharing this bug, if you don't mind could you please raise the PR to fix this issue.

nboss3 pushed a commit to nboss3/Watcher_Fork that referenced this issue Nov 12, 2024
fix: Ubuntu/Mint compatibility patch (Waishnav#37)
0c5de6e 
Added function for detecting master process when vim process and terminal is detected, may need further testing on other linux systems.
nboss3 pushed a commit to nboss3/Watcher_Fork that referenced this issue Nov 12, 2024
Fix: Ubuntu/Mint compatibility patch (Waishnav#37)
16e9852
Waishnav pushed a commit that referenced this issue Nov 13, 2024
@nboss3
Fix: Ubuntu/Mint compatibility patch (#37) (#48)
65146e8 
* fix: Ubuntu/Mint compatibility patch (#37)
Added function for detecting master process when vim process and terminal is detected, may need further testing on other linux systems.

* Fix: Ubuntu/Mint compatibility patch (#37)

* Updated vim detection function - terminal detection bug unfortunately unfixable

* removed changed vim detection behaviour

---------

Co-authored-by: nboss3 <nicholasjames@live.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dishantzaveri dishantzaveri

Labels
good first issue Good for newcomers low-code non-code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nboss3 @dishantzaveri @Waishnav