Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"--" in domain story breaks SVG #171

Open
hofstef opened this issue Oct 2, 2024 · 0 comments
Open

"--" in domain story breaks SVG #171

hofstef opened this issue Oct 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@hofstef
Copy link
Member

hofstef commented Oct 2, 2024

Describe the bug
If two minus characters ("--") are used anywhere in the domain story (title, description, labels, annotation), the SVG export will be broken.
The reason is that the SVG file contains an embedded EGN file as comment:

<!-- <DST>
  {
     (domain story as JSON)
  }
</DST> -->

If the JSON contains "--", SVG viewers will interpret this as closing tag of the comment. The rest of the comment is interpreted as SVG content and hence leads to an error when the viewer tries to render it.

Version

  • Egon: v2.0.0-2.2.0
@hofstef hofstef added the bug Something isn't working label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant