Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OR string and email subject translations are missing #19

Open
NikoVee opened this issue Mar 17, 2023 · 3 comments
Open

OR string and email subject translations are missing #19

NikoVee opened this issue Mar 17, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@NikoVee
Copy link

NikoVee commented Mar 17, 2023

Hey there,

Cool plugin btw! I noticed that the string OR isn’t translating at the first stage of the process in login (Before hitting the login via magic url) but it translates after you have pressed the (login via magic url).

It also seems that the “Sign in to” string is missing from that should translate the subject of the email.

Found couple others in the emails:
String: Sign in to %s (The button)
String: If you did not make this request, you can safely ignore this email.
String: This email has been sent from:

Could you add these for the translation strings?

I have posted about these bugs in the WordPress forums also 2 months ago that can be found here: https://wordpress.org/support/topic/or-string-and-email-subject-translations-are-missing/ (That you could easily tick off also when the strings are added :D)

@techjewel techjewel added the enhancement New feature or request label Mar 17, 2023
@techjewel
Copy link
Contributor

Thanks for reporting. If you are a developer you can definitely submit a pull request in this repository. Otherwise, We will make all the strings as translation ready.

@NikoVee
Copy link
Author

NikoVee commented Mar 17, 2023 via email

@NikoVee
Copy link
Author

NikoVee commented Mar 23, 2023

Hey @techjewel

Since this is still open i noticed another string:
You are trying too much. Please try after 30 minutes

It is translatable in the files but the actual translation doesn't seem to be working.

tdrayson added a commit to tdrayson/fluent-auth that referenced this issue Nov 19, 2024
Fixes missing translation reported in WPManageNinja#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants