Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Shortcode attributes #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HenrijsS
Copy link

@HenrijsS HenrijsS commented Oct 24, 2024

Wanted to finally contribute something to oss, so I added the option to use attributes/variables to shortcodes.
For each snippet is a tag-like selector which forces you to select what variables to use in the script and shortcode (otherwise any shortcode user could overwrite any variables in the whole function).

Let me know if there's anything else to change.

References: #27

P.S.: I think the last Commit didn't run as npx mix --production but commited the same watch. That's why there's a ton of removals. Probably all the whitespace in app.js

Github Copilot Summary

This pull request introduces functionality for handling shortcode attributes in snippets. The changes span multiple files, adding new methods and updating existing ones to support this feature.

Shortcode Attributes Handling:

Frontend Components:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants