Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show share options even if navigator.share is disabled #63

Open
ebroda opened this issue May 11, 2024 · 1 comment
Open

Show share options even if navigator.share is disabled #63

ebroda opened this issue May 11, 2024 · 1 comment
Assignees
Labels
bug Something isn't working community redefine

Comments

@ebroda
Copy link
Member

ebroda commented May 11, 2024

In Firefox navigator.share is disabled by default and therefore the share icon isn't shown.
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/share#browser_compatibility

Scheinbar nutzt ihr für das die share()-Methode genutzt, die ist in Firefox aber per Default deaktiviert.
Nur wenn man “dom.webshare.enabled preference (needs to be set to true)” in about:config setzt, wird das korrekt befüllt und angezeigt.
Hier wäre also nochmal n Fallback für Firefox bzw. wenn die Methode nicht verfügbar ist, zu prüfen, dass es sonst einfach in die Zwischenablage kopiert wird.

The corresponding file has an explicit check for navigator.share:

if (navigator.share) {

A possibility would be to add an els branch and remove isShareMobile.

} else {
navigator.clipboard.writeText(this.text)
}

But the user should also get a hint, that something has happened. Best would probably to trigger as message box like in other cases (e.g. on save) - but I'm not sure if that's possible to be triggered from here as the Notifications are in pool-webapp?

@FriedhelmW
Copy link

If you want, you can try to build it :-)
If you need further feedback for the notification trigger pleas give the card the redefine label and assigne it to Tobi, but it can take a while because the MTG has priority right now.

@FriedhelmW FriedhelmW added the bug Something isn't working label May 15, 2024
TobiKaestle added a commit that referenced this issue Nov 25, 2024
added copy text and emitting trigger for share icons #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community redefine
Projects
None yet
Development

No branches or pull requests

4 participants