New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModalDialogViewModelBase improvement #16

Open

molnard opened this issue Jan 31, 2019 · 0 comments

Contributor

molnard commented Jan 31, 2019

Make CancelCommand virtual
Add something like virtual OnShown or observable property. I would like to start my operations at that phase. Now if I create a dialog and call Close before the call of ShowDialogAsync then dialogCloseCompletionSource will generate NRE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment