Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Order number unique in db #113

Open
asvishnyakov opened this issue Sep 12, 2019 · 3 comments
Open

Make Order number unique in db #113

asvishnyakov opened this issue Sep 12, 2019 · 3 comments

Comments

@asvishnyakov
Copy link
Contributor

While we require and generate unique order numbers, there are no restrictions in db for it

@5309
Copy link

5309 commented Sep 13, 2019

We generate unique Order numbers by default, but we should not restrict Order number to be unique. For example, the same Virto Commerce installation might be used by a few legal entities with the same kind of Order number sequences. In this case, there might be few orders with the same Order number.

The problem is that API method /api/order/customerOrders/number/{number} is designed to return only one Order by number.

@tatarincev how it can be resolved?

@asvishnyakov
Copy link
Contributor Author

Not only this one, but in storefront too

@tatarincev
Copy link
Contributor

tatarincev commented Sep 18, 2019

I think that this method /api/order/customerOrders/number/{number} should be marked as Obsoleted with future remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants