Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for processing results in individual processes before saving #1

Open
corykinney opened this issue Sep 5, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@corykinney
Copy link
Contributor

Currently, the _run_simulation function that is submitted to the ProcessPoolExecutor saves the results to a file; thus, any results processing, such as calculating ignition delay times or retrieving top species, must then reload the simulation from the file in the main process after the simulation process completes. Instead, a custom function (Callable[[Simulation], ...]) that can be executed on the simulation process should be available as a keyword argument or a staticmethod that can be overridden.

@corykinney corykinney added the enhancement New feature or request label Sep 5, 2024
corykinney added a commit that referenced this issue Sep 9, 2024
corykinney added a commit that referenced this issue Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant