Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:[#427] refuse to remove stack if in use #430

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix:[#427] refuse to remove stack if in use #430

merged 1 commit into from
Nov 14, 2024

Conversation

jardon
Copy link
Member

@jardon jardon commented Nov 14, 2024 •
edited
Loading

  • add check for stack in use before removing subsystem
  • add error message for in use stack in locales
./apx stacks rm -n noble
  ERROR   The stack is used in 1 subsystems:
┼┄┄┄┄┄┄┄┄┄┄┄┄┄┄┼┄┄┄┄┄┄┄┼┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┼┄┄┄┄┄┄┼
┊ NAME         ┊ STACK ┊ STATUS                   ┊ PKGS ┊
┼┄┄┄┄┄┄┄┄┄┄┄┄┄┄┼┄┄┄┄┄┄┄┼┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┼┄┄┄┄┄┄┼
┊ vso-waydroid ┊ noble ┊ Exited (130) 5 weeks ago ┊ 0    ┊
┼┄┄┄┄┄┄┄┄┄┄┄┄┄┄┼┄┄┄┄┄┄┄┼┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┼┄┄┄┄┄┄┼

relates #427

@jardon
fix:[Vanilla-OS#427] refuse to remove stack if in use
8583d99 
- add check for stack in use before removing subsystem
- add error message for in use stack in locales
taukakao
taukakao approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@taukakao taukakao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jardon jardon merged commit ed83288 into Vanilla-OS:main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taukakao taukakao taukakao approved these changes

@kbdharun kbdharun kbdharun approved these changes

@mirkobrombin mirkobrombin Awaiting requested review from mirkobrombin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jardon @kbdharun @taukakao