Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-editor doesn't detect broken config #333

Open
taukakao opened this issue Jul 28, 2024 · 3 comments
Open

config-editor doesn't detect broken config #333

taukakao opened this issue Jul 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@taukakao
Copy link
Member

If you create an invalid config, abroot config-editor will save it anyway and will not be able to run again to fix the issue.

@taukakao taukakao added the bug Something isn't working label Jul 28, 2024
@taukakao taukakao added this to the 2-after-stable milestone Jul 28, 2024
@taukakao taukakao moved this to Todo in 2 - Orchid Jul 28, 2024
@mirkobrombin
Copy link
Member

A built-in editor is probably the best solution here, so we validate it before saving.

@taukakao
Copy link
Member Author

@mirkobrombin
I think a built-in editor would be overkill.
We could alternatively copy the file somewhere in /tmp, edit it there and validate it before writing it back to /etc/abroot

@mirkobrombin
Copy link
Member

I would define it as "overkill" but complex. Anyway your idea is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants