Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to only display logo when we find results #172

Open
frizensami opened this issue Jun 22, 2022 · 2 comments
Open

Option to only display logo when we find results #172

frizensami opened this issue Jun 22, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@frizensami
Copy link
Collaborator

No description provided.

@frizensami frizensami added the enhancement New feature or request label Jun 22, 2022
@huyz
Copy link

huyz commented Jun 22, 2022

Is there a reason to make that an option instead of just make that behavior by default?
I'm afraid of option explosions.

@frizensami
Copy link
Collaborator Author

That's a fair point. There are a few things we can do re: showing the button:

  1. Only show the button when we have "exact" results (probably too conservative)
  2. Show the button when we have any results at all (this seems reasonable)
  3. Show the button at all times (allows users to click on our option to search through google given that no results are found).

Seems like option 2 is a good default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huyz @frizensami