-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientDriven Sample - Welcome Dialog and Table of Contents [MTT-8693] [MTT-8697] #262
base: develop
Are you sure you want to change the base?
Conversation
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a suggestion for the forum link, but that's probably fine to land without it.
Regarding the icons, @selenaayang did a pass on the new Template with updated designs, maybe you'd like to re-use them in the sample too: https://jira.unity3d.com/browse/MTT-9640, but again, not blocking if we want to land this PR.
Text: | ||
m_Untranslated: Ask questions and get help on Netcode for GameObjects | ||
Metadata: | ||
Url: https://forum.unity.com/forums/netcode-for-gameobjects.661/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the link to the old forum, it has a redirect but maybe we should link to discussion directly
https://discussions.unity.com/tags/c/unity-engine/52/netcode-for-gameobjects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, I will replace it!
Will also switch out the icons - if they're new we should use them :)
Addressed the comments @bastienunity , please have a quick look again 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the icons path should be clean to avoid any unforeseen issues with strange characters in the Assets folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all the new icons have a weird 🔷 symbols in their path. Not sure if that might an issue on some os?
Description
Adds the standard Welcome Dialog and Table of Contents from the in-editor tutorials package to the ClientDriven Sample.
Issue Number(s)
https://jira.unity3d.com/browse/MTT-8693
https://jira.unity3d.com/browse/MTT-8697
Contribution checklist