Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientDriven Sample - Welcome Dialog and Table of Contents [MTT-8693] [MTT-8697] #262

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

FabianStoll
Copy link

Description

Adds the standard Welcome Dialog and Table of Contents from the in-editor tutorials package to the ClientDriven Sample.

Issue Number(s)

https://jira.unity3d.com/browse/MTT-8693
https://jira.unity3d.com/browse/MTT-8697

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@FabianStoll FabianStoll marked this pull request as ready for review November 27, 2024 17:02
@FabianStoll FabianStoll requested a review from a team as a code owner November 27, 2024 17:02
bastienunity
bastienunity previously approved these changes Nov 28, 2024
Copy link
Contributor

@bastienunity bastienunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion for the forum link, but that's probably fine to land without it.
Regarding the icons, @selenaayang did a pass on the new Template with updated designs, maybe you'd like to re-use them in the sample too: https://jira.unity3d.com/browse/MTT-9640, but again, not blocking if we want to land this PR.

Text:
m_Untranslated: Ask questions and get help on Netcode for GameObjects
Metadata:
Url: https://forum.unity.com/forums/netcode-for-gameobjects.661/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the link to the old forum, it has a redirect but maybe we should link to discussion directly
https://discussions.unity.com/tags/c/unity-engine/52/netcode-for-gameobjects

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, I will replace it!
Will also switch out the icons - if they're new we should use them :)

@FabianStoll
Copy link
Author

FabianStoll commented Nov 29, 2024

Addressed the comments @bastienunity , please have a quick look again 🙂

Copy link
Contributor

@bastienunity bastienunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the icons path should be clean to avoid any unforeseen issues with strange characters in the Assets folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all the new icons have a weird 🔷 symbols in their path. Not sure if that might an issue on some os?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants