Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not merge: Adding transform configuration for playtest purposes #131

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

fluong6
Copy link
Contributor

@fluong6 fluong6 commented Jul 19, 2023

Description

Issue Number(s)

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fluong6 fluong6 added the DO NOT MERGE Do not merge this PR! label Jul 19, 2023
@fluong6 fluong6 changed the title Adding transform configuration Do not merge: Adding transform configuration for playtest purposes Jul 19, 2023
Just updating to develop until the v1.5.2 branch is created.
Copy link

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
You can select with a mouse or by hitting the corresponding numeric key.
I updated the manifest to point to develop until the v1.5.2 branch is created.
Other than that, I think we are good to go as far as using the ClientDriven for hosted tests.
We will circle back to do the content selection stuff.
👍 💯

@NoelStephensUnity
Copy link

@fluong6
You might want to remove the Windows Build folder.

@fluong6
Copy link
Contributor Author

fluong6 commented Nov 9, 2023

@NoelStephensUnity Since we are using ClientDriven_TestingTool branch as our main ClientDriven Test tool branch for our playtest, I was planning to use this branch (feature/adding-transform-configuration) as a sandbox.

Last night before, I was making change locally in a window machine at the office and planned to continue to work on those changes at home today. That's why I committed everything. 😛

Reverting the changes soon.

This reverts commit 876b1f8.
@unity-cla-assistant
Copy link

unity-cla-assistant commented Mar 12, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ NoelStephensUnity
❌ fluong6
You have signed the CLA already but the status is still pending? Let us recheck it.

@RikuTheFuffs
Copy link
Contributor

@fluong6 and @NoelStephensUnity doing some cleanup here, is this PR still needed or can we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants