Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename liquidityDelta in IPoolManager.ModifyPositionParams #746

Open
snreynolds opened this issue Jun 18, 2024 · 5 comments
Open

Rename liquidityDelta in IPoolManager.ModifyPositionParams #746

snreynolds opened this issue Jun 18, 2024 · 5 comments
Labels

Comments

@snreynolds
Copy link
Member

Component

General design optimization (improving efficiency, cleanliness, or developer experience)

Describe the suggested feature and problem it solves.

I think the term "delta" should be conventionally used to describe credits or debits in token0 or token1 owed to or from the pool manager.

not sure of a better name tho... just liquidity?

Describe the desired implementation.

No response

Describe alternatives.

No response

Additional context.

No response

Copy link

linear bot commented Jun 18, 2024

PROTO-282 Rename liquidityDelta in IPoolManager.ModifyPositionParams

@wjmelements
Copy link
Contributor

liquidityDelta is a fine name for the liquidity delta. Delta is a good term for any signed integer exclusively used for addition.

@tom2o17
Copy link

tom2o17 commented Jun 27, 2024

I like Delta given it refers to the change in liquidity for the position being modified.

@snreynolds
Copy link
Member Author

I think that I had wanted to change callerDelta -> liquidityDelta in the return variables to match swap's swapDelta which means I dont want it to be overloaded with the params

@snreynolds
Copy link
Member Author

related to this #742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants