Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Deployers.createPool from private to internal or public #427

Closed
ferencdg opened this issue Nov 24, 2023 · 2 comments
Closed

Change Deployers.createPool from private to internal or public #427

ferencdg opened this issue Nov 24, 2023 · 2 comments
Labels

Comments

@ferencdg
Copy link

Component

No response

Describe the suggested feature and problem it solves.

please make this function internal or public:

function createPool(
PoolManager manager,
IHooks hooks,
uint24 fee,
uint160 sqrtPriceX96,
bytes memory initData
) private returns (PoolKey memory key, PoolId id)

The general flow of creating hooks in Tests is:

create the PoolManager with Deployers.createPoolManager()
create the Hook and pass in the poolManager
create the pool with Deployers.createPool

Describe the desired implementation.

No response

Describe alternatives.

No response

Additional context.

No response

@saucepoint
Copy link
Collaborator

Looks like the helper contract was changed recently, pool creation is now available as initPool(internal)

#407

@snreynolds
Copy link
Member

Closing - that PR should help pool creation. Let us know if this doesn't resolve your request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants