Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: integration testing for proposal checks #31

Open
moodysalem opened this issue Sep 30, 2021 · 1 comment
Open

test: integration testing for proposal checks #31

moodysalem opened this issue Sep 30, 2021 · 1 comment

Comments

@moodysalem
Copy link
Contributor

running it locally is good, but is manual testing, and checks can break

would be good to have some automated tests that verify the results of checks on individual proposals

e.g.: for the verify etherscan check, pass in some proposal data that calls a target with unverified code, and separately pass in a proposal that calls verified code, and check the resulting output of the check

these tests are integration testing because they rely on external apis

@moodysalem
Copy link
Contributor Author

actually, maybe we should just run the whole thing on pull requests in a mode that does not write to the github repo (which is pretty much integration testing)

@mds1 mds1 changed the title integration testing for checks test: integration testing for proposal checks Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant