You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
running it locally is good, but is manual testing, and checks can break
would be good to have some automated tests that verify the results of checks on individual proposals
e.g.: for the verify etherscan check, pass in some proposal data that calls a target with unverified code, and separately pass in a proposal that calls verified code, and check the resulting output of the check
these tests are integration testing because they rely on external apis
The text was updated successfully, but these errors were encountered:
actually, maybe we should just run the whole thing on pull requests in a mode that does not write to the github repo (which is pretty much integration testing)
mds1
changed the title
integration testing for checks
test: integration testing for proposal checks
Feb 2, 2022
running it locally is good, but is manual testing, and checks can break
would be good to have some automated tests that verify the results of checks on individual proposals
e.g.: for the verify etherscan check, pass in some proposal data that calls a target with unverified code, and separately pass in a proposal that calls verified code, and check the resulting output of the check
these tests are integration testing because they rely on external apis
The text was updated successfully, but these errors were encountered: