Misc. function fixes #1707
Draft
Misc. function fixes #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
|
Is this going to be obsoleted by @colinator27's new decompiler? |
|
I'm a bit late to this commentary, but I don't believe so. Most of the changes included here are compiler-side. It'll definitely require adjustment, though, and I'm happy to wait and fix it up after the new decompiler is in, as well as checking how function renaming works under Underanalyzer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix decompilation and recompilation of anonymous functions and object functions, as well as renaming functions (previously caused a decompiler crash due to two gml_Script entries with the same offset). Closes #1428. Closes #565.
Caveats
This is highly untested at the moment, but in this particular field I don't think it's possible for anything to regress unless the whole tool crashes.
Notes
N/A