Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected option in semSearch dropdown may get stuck on non-preferred label after deep link #496

Open
jgonggrijp opened this issue Jul 30, 2021 · 0 comments
Labels
cosmetic Something is less pretty than possible

Comments

@jgonggrijp
Copy link
Member

jgonggrijp commented Jul 30, 2021

A very minor issue left after #495:

Select2 has the annoying property that if you select an <option>, it will no longer update its contents afterwards. Before 9c1ba6c, this resulted in chosen types and predicates in the semantic search dropdowns having blank labels when re-visiting the search form through a deep link. I mostly fixed it by adding more event handling steps, but due to our complex data model, the label of an option sometimes updates more than once. As a result, the Reader class may appear labeled as "Person" in this scenario.

@jgonggrijp jgonggrijp added the cosmetic Something is less pretty than possible label Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetic Something is less pretty than possible
Projects
None yet
Development

No branches or pull requests

1 participant