From 9e09f1993e2dcaceba7f9d38b905a432b102715d Mon Sep 17 00:00:00 2001 From: Ramin Farhadi Date: Wed, 6 Dec 2023 11:54:56 -0500 Subject: [PATCH 1/3] h3 tag was changed to p In the markup, the In this issue section is positioned above the H1 tag, which is not an appropriate way to display it in regard to SEO. Therefore, I have changed the H3 tag to a paragraph (p) --- functions/display-logic.php | 4 ++-- package-lock.json | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/functions/display-logic.php b/functions/display-logic.php index a0f8454a..4e5340d6 100644 --- a/functions/display-logic.php +++ b/functions/display-logic.php @@ -11,7 +11,7 @@ * @author Cadie Stockman * @return string HTML markup for the story **/ -function display_story_callout( $story, $css_class='', $show_category=false, $thumbnail_size='frontpage-story-thumbnail', $heading='h3' ) { +function display_story_callout( $story, $css_class='', $show_category=false, $thumbnail_size='frontpage-story-thumbnail', $heading='p' ) { if ( ! $story ) return false; $thumbnail = null; @@ -52,7 +52,7 @@ function display_story_callout( $story, $css_class='', $show_category=false, $th
- < class="story-callout-title hover-child-text-underline"> + < class="h3 story-callout-title hover-child-text-underline"> >
diff --git a/package-lock.json b/package-lock.json index 60e95069..c8a15801 100644 --- a/package-lock.json +++ b/package-lock.json @@ -4,7 +4,6 @@ "requires": true, "packages": { "": { - "name": "Pegasus-Theme", "devDependencies": { "@babel/cli": "^7.17.6", "@babel/core": "^7.17.8", From 7783f502d42c1d80d2ba4ab6ea585332840de2e4 Mon Sep 17 00:00:00 2001 From: Ramin Farhadi Date: Wed, 6 Dec 2023 12:45:20 -0500 Subject: [PATCH 2/3] span tag was passed to Display_story_callout in order to change the h3 tag to span only for in-this-issue section --- front-page.php | 2 +- functions/display-logic.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/front-page.php b/front-page.php index 82ad9241..477a1af4 100644 --- a/front-page.php +++ b/front-page.php @@ -108,7 +108,7 @@
- +
diff --git a/functions/display-logic.php b/functions/display-logic.php index 4e5340d6..5318d5c4 100644 --- a/functions/display-logic.php +++ b/functions/display-logic.php @@ -11,7 +11,7 @@ * @author Cadie Stockman * @return string HTML markup for the story **/ -function display_story_callout( $story, $css_class='', $show_category=false, $thumbnail_size='frontpage-story-thumbnail', $heading='p' ) { +function display_story_callout( $story, $css_class='', $show_category=false, $thumbnail_size='frontpage-story-thumbnail', $heading='h3' ) { if ( ! $story ) return false; $thumbnail = null; From 05700e67feac47713e268da809828b722171c0cb Mon Sep 17 00:00:00 2001 From: Ramin Farhadi Date: Wed, 6 Dec 2023 12:56:08 -0500 Subject: [PATCH 3/3] 4th argument was replaced with empty string --- front-page.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/front-page.php b/front-page.php index 477a1af4..d43ed2bb 100644 --- a/front-page.php +++ b/front-page.php @@ -108,7 +108,7 @@
- +