Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail Harder? #1315

Open
mattleblanc opened this issue Feb 7, 2019 · 3 comments
Open

Fail Harder? #1315

mattleblanc opened this issue Feb 7, 2019 · 3 comments

Comments

@mattleblanc
Copy link
Contributor

Hi all,

I just spent a set of grid jobs making some empty trees. It's not the end of the world, but I've seen others make this mistake in the past as well: if any of the detail strings in the TreeAlgo has a typo in it, jobs will proceed and appear to work, but produce only empty trees at the end of the day.

It seems to me that it would be better for users and from a resource-management point of view if this algorithm crashed and burned immediately, rather than silently proceeding ...

🍻 MLB

@kratsg
Copy link
Contributor

kratsg commented Feb 7, 2019

I just spent a set of grid jobs making some empty trees. It's not the end of the world, but I've seen others make this mistake in the past as well: if any of the detail strings in the TreeAlgo has a typo in it, jobs will proceed and appear to work, but produce only empty trees at the end of the day.

It seems to me that it would be better for users and from a resource-management point of view if this algorithm crashed and burned immediately, rather than silently proceeding ...

Good idea. We can do some quick (and nice) parsing of the C++ source files for special algorithms.

@kkrizka
Copy link
Contributor

kkrizka commented Feb 8, 2019

A better solution would be for the info switch classes to throw an error if it detects a string it cannot parse.

@kratsg
Copy link
Contributor

kratsg commented Feb 8, 2019

A better solution would be for the info switch classes to throw an error if it detects a string it cannot parse.

We can't do this during config time (or at least not before the job is submitted), can we?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants