Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[song-directory-transpose] Decide which "qualities" should be ported upstream #13

Open
jgvictores opened this issue May 27, 2017 · 7 comments

Comments

@jgvictores
Copy link
Member

jgvictores commented May 27, 2017

Decide which "qualities" should be ported upstream

  • Source: this hackish line:

    afterSplit = re.split(" |-|!|\.\.\.|\.\.|: |\*|high|open|bass|riff|palm mute|notes|m6|madd11/|m7add11/|7sus2|8|m7b5|madd13|add13", stringToProcess, 1) # 3rd parameter is maxsplit # Also works with single space, do this to catch faulty txt.

  • Destination: this upstream file

  • EDIT: Current source:

    afterSplit = re.split(" |_|!|\.\.\.|\.\.|: |\*|high|open|bass|riff|palm mute|notes|m6|madd11/|m7add11/|7sus2|8|m7b5|madd13|add13", stringToProcess, 1) # 3rd parameter is maxsplit # Also works with single space, do this to catch faulty txt.

@jgvictores
Copy link
Member Author

@jgvictores
Copy link
Member Author

This just became an issue, because - was used as a delimiter.

@jgvictores
Copy link
Member Author

jgvictores commented Nov 4, 2017

Reverted e11eec5 with a forced push for now.

@jgvictores
Copy link
Member Author

Blocked by #21, which should prevent previously stated fact.

@jgvictores
Copy link
Member Author

Blocked by #21, which should prevent previously stated fact.

Which makes it no longer upstream.

@jgvictores
Copy link
Member Author

Finally unblocked thanks to #21!!!

@jgvictores
Copy link
Member Author

Note that some are already implemented, but as - instead of m, example 7-13, and are now possible without porting upstream.

@jgvictores jgvictores changed the title Decide which "qualities" should be ported upstream [song-directory-transpose] Decide which "qualities" should be ported upstream Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant