Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove smartdialog #980

Closed
dave-doty opened this issue Sep 6, 2024 · 0 comments
Closed

remove smartdialog #980

dave-doty opened this issue Sep 6, 2024 · 0 comments
Assignees
@dave-doty

Comments

@dave-doty
Copy link
Member

The smartdialog package is the only one we use that does not support null safety. It's only used in two places, for setting the length of loopouts, and extensions. Replace with our custom Dialog class and remove the dependency, in preparation for #419.
@dave-doty dave-doty self-assigned this Sep 6, 2024
@dave-doty dave-doty mentioned this issue Sep 6, 2024
Merged
dave-doty added a commit that referenced this issue Sep 6, 2024
@dave-doty
Merge pull request #981 from UC-Davis-molecular-computing/980-remove-…
b876256 
…smartdialog

closes #980: remove smart_dialog package dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dave-doty dave-doty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dave-doty