Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window control by section #186

Open
dennmuel opened this issue Jul 24, 2020 · 0 comments
Open

Window control by section #186

dennmuel opened this issue Jul 24, 2020 · 0 comments

Comments

@dennmuel
Copy link
Member

Is there a specific reason, why the hex win_id values needed e.g. for moving and deleting windows are gathered via the section (quadrant / current position on the monitor) and not by the primary db-key?

It seems to be quite easy to produce a state, where a new and an existing window would have the same section value:

  1. Add two windows. (id=1 has section=1 and id=2 has section=2)
  2. Switch their sections. (id=1 has section=2 and id=2 has section=1)
  3. Delete one window. (E.g. there's now only id=2 with section=1)
  4. Add a new window. (Now there's id=1 with section=1 and id=2 with section=1)

Ultimately, I think it comes down to assigning id and section individually and not derive them from the same value as it's currently happening: https://github.com/UB-Mannheim/PalMA/blob/master/control.php#L273-L279

Still I haven't understood, why all the window controls work via section (called "window" in the request) and not id in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant