Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use privileged mode for ICMP only on Windows #748

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Use privileged mode for ICMP only on Windows #748

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aecca63
fix: Use privileged mode for ICMP only on Windows
TwiN Apr 28, 2024
a3f3660
Merge branch 'master' into fix/icmp
TwiN Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,12 +238,8 @@ func Ping(address string, config *Config) (bool, time.Duration) {
pinger := ping.New(address)
pinger.Count = 1
pinger.Timeout = config.Timeout
// Set the pinger's privileged mode to true for every GOOS except darwin
// See https://github.com/TwiN/gatus/issues/132
//
// Note that for this to work on Linux, Gatus must run with sudo privileges.
// See https://github.com/prometheus-community/pro-bing#linux
pinger.SetPrivileged(runtime.GOOS != "darwin")
// See https://github.com/TwiN/gatus/issues/132 and https://github.com/TwiN/gatus/issues/697
pinger.SetPrivileged(runtime.GOOS == "windows")
pinger.SetNetwork(config.Network)
err := pinger.Run()
if err != nil {
Expand Down
Loading