Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Jump-Climb to edge from standing position with free space at front #642

Open
Abendlied opened this issue May 24, 2024 · 4 comments
Open

Comments

@Abendlied
Copy link

Abendlied commented May 24, 2024

Game:
Gothic I & Gothic II NotR

Short Description/Observation:
Cannot jump-climb to an edge on top of the player from standing position if there is room to jump forward. Game will always default to forward-jump instead of climb-jump.

Steps to reproduce:
position player under a climbable edge with still some space in front of the player (not standing directly with the face touching the wall)

Additional information
Savegame for Gothic 1: save_slot_14.sav.tar.gz
Video (3 sec, 1.3 MiB): https://github.com/Try/OpenGothic/assets/86957596/b31b9dcd-dc82-4b73-a7de-4a40840dfd27
More videos:
climb1
climb2

Savegame for Gothic 2 NotR:
save_slot_11.sav.tar.gz

related to but not really covered by #312

edit: added G2 savegame, applies to G1 and G2NotR

@Nindaleth
Copy link
Contributor

Is this Gothic I specific? I think the issue is similarly present in G2.

@Abendlied
Copy link
Author

@Nindaleth you are right, it applies to G2 as well.
Savegame for Gothic 2 NotR:
save_slot_11.sav.tar.gz

@Abendlied Abendlied changed the title [Gothic 1] Cannot Jump-Climbing to edge from standing position with free space at front Cannot Jump-Climbing to edge from standing position with free space at front May 26, 2024
@Abendlied Abendlied changed the title Cannot Jump-Climbing to edge from standing position with free space at front Cannot Jump-Climb to edge from standing position with free space at front Aug 1, 2024
@Abendlied
Copy link
Author

playercontrol.cpp has conditions jumping from standing position:

else if(pl.isStanding()) { auto jump = pl.tryJump(); if(!pl.isFalling() && !pl.isSlide() && jump.anim!=Npc::Anim::Jump){ pl.startClimb(jump); return; } ani = Npc::Anim::Jump; } else { ani = Npc::Anim::Jump;

could we change the condition defaulting to startClimb first and only if that does not work, try jump?

@Abendlied Abendlied mentioned this issue Aug 12, 2024
@Try
Copy link
Owner

Try commented Aug 14, 2024

Added videos, from #666, to description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants