Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure loggin method works, #30

Open
2 tasks
a-t-0 opened this issue Jul 14, 2024 · 0 comments
Open
2 tasks

Ensure loggin method works, #30

a-t-0 opened this issue Jul 14, 2024 · 0 comments

Comments

@a-t-0
Copy link
Member

a-t-0 commented Jul 14, 2024

opening the hitrate counter log file in VScode shows that "validInvestments": 0 are sometimes changed to 1 and then overwritten to 0 whilst only the didNotreachInvestmentCeiling counter increases.

  • Verify that (almost) all branches are hit using emit log statements.
  • Fix this to get the actual count as output.

I expect this happens in the for loops with respect to the keys length and a potential difference in the values length of the mapping and any checks on their respectives lengths that prevent reaching certain counting/copying for loops.
Alternative hypothesis is that the compiler/something sorts the mapping and/or struct in some way leading to just the first entry getting a 1 and the rest 0s.

Determine why the logs are not outputted/updated with the correct values. In the CLI output, you can search on:
.get("i") or some other letter if another case is hit randomly. (Preferably "i" because that is updated just before logging.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant