Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Sanity checking H/r_p for user-specified global linear perturbations #34

Open
TomHilder opened this issue Jun 8, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@TomHilder
Copy link
Owner

Quoted from PR #21 :

Tom: I feel there needs to be a further sanity-check/warning in the case that the user is providing either global or simulation perturbations. H/r_p needs to be identical in the provided data and as specified to wakeflow no? It would be good to really reinforce this to the user (obviously we can't actually check the H/r_p in the linear perturbations they provide).

Daniele: Actually we could do something about it, maybe we can work on this together when you are in nice. Andrés is parsing the log files in discminer, checking if they are compliant with the standard nomenclature. We could change the names of the perturbations accounting for the different parameters and parse the name of the files, checking if H/r_p is actually the same

@TomHilder TomHilder added the enhancement New feature or request label Jun 8, 2023
@TomHilder TomHilder added this to the Nice visit updates milestone Jun 8, 2023
@TomHilder TomHilder self-assigned this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant