[enhancement] Improve mcfost
interface to allow users to edit .para file parameters
#27
Labels
enhancement
New feature or request
The interface to
mcfost
should be changed such thatwakeflow
only specifies the strictly required parameters from the.para
config file formcfost
.Currently,
wakeflow
tellsmcfost
the necessary grid and physics, but also guesses some other parameters that are probably sensible for the user but potentially not desired. It is also NOT documented what these are and why they are the specific values. This is definitely poor practice. This should be changed such that besides the required physics parameters, the other parameters are (somehow) set by the user. Probably just by having them provide a.para
file, where the necessary parameters are overridden bywakeflow
.Additionally, the
mcfost
parameter file is currently distributed withwakeflow
. This is bad practice.wakeflow
should include a script to download the.para
file using the user'smcfost
installation.Finally,
mcfost
should be called using therun
function frompymcfost
instead of using asys
call tomcfost
. This is more effectively future-proof aspymcfost
is more likely to be updated as required thanwakeflow
's interface. It would also allow the user to pass through additional keywords for callingmcfost
as they are arguments in thepymcfost
function.The text was updated successfully, but these errors were encountered: