Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Improve warnings and exceptions system #25

Open
TomHilder opened this issue Jun 2, 2023 · 0 comments
Open

[enhancement] Improve warnings and exceptions system #25

TomHilder opened this issue Jun 2, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@TomHilder
Copy link
Owner

wakeflow errors and warnings should be changed to adhere to standard Python conventions.

Currently, wakeflow uses print statements to warn users about certain parameter choices, and generic Exceptions for incompatible or otherwise non-sensical parameter choices. This does not really adhere to standard practice; warnings.warn should be used for the warnings, and more specific errors should be used instead of Exceptions. For example ValueError for a bad parameter choice. The current implementation is due to my limited knowledge of error handling at the time I wrote the code. Users should be able to catch certain warnings and errors and handle them appropriately if they desire, which is impossible in the current implementation.

@TomHilder TomHilder added the enhancement New feature or request label Jun 2, 2023
@TomHilder TomHilder changed the title Improve warnings and exceptions system [enhancement] Improve warnings and exceptions system Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant