You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
wakeflow errors and warnings should be changed to adhere to standard Python conventions.
Currently, wakeflow uses print statements to warn users about certain parameter choices, and generic Exceptions for incompatible or otherwise non-sensical parameter choices. This does not really adhere to standard practice; warnings.warn should be used for the warnings, and more specific errors should be used instead of Exceptions. For example ValueError for a bad parameter choice. The current implementation is due to my limited knowledge of error handling at the time I wrote the code. Users should be able to catch certain warnings and errors and handle them appropriately if they desire, which is impossible in the current implementation.
The text was updated successfully, but these errors were encountered:
wakeflow
errors and warnings should be changed to adhere to standard Python conventions.Currently,
wakeflow
usesprint
statements to warn users about certain parameter choices, and genericExceptions
for incompatible or otherwise non-sensical parameter choices. This does not really adhere to standard practice;warnings.warn
should be used for the warnings, and more specific errors should be used instead ofExceptions
. For exampleValueError
for a bad parameter choice. The current implementation is due to my limited knowledge of error handling at the time I wrote the code. Users should be able to catch certain warnings and errors and handle them appropriately if they desire, which is impossible in the current implementation.The text was updated successfully, but these errors were encountered: