Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing actions from resource card #35

Closed
ridoo opened this issue Aug 8, 2024 · 13 comments
Closed

Missing actions from resource card #35

ridoo opened this issue Aug 8, 2024 · 13 comments
Assignees

Comments

@ridoo
Copy link
Collaborator

ridoo commented Aug 8, 2024

The action items Delete and Copy are missing from the actions drop down list:

Image

Perhaps, this is a regression from updating to 4.2.5.

There are lots of changes in the localConfig.json. We have to review and sync it with the latest changes from upstream.

Part of #30

@ridoo ridoo added the bug Something isn't working label Aug 8, 2024
@ridoo ridoo changed the title Missing Download and Copy actions in catalog Align localConfig configuration with latest changes Aug 8, 2024
@ridoo ridoo changed the title Align localConfig configuration with latest changes Missing actions from resource card Aug 8, 2024
@ridoo
Copy link
Collaborator Author

ridoo commented Aug 8, 2024

Seems, that I had an inconsistent state .. however, we have to align the localConfig.json for 4.3.x.

@ridoo ridoo removed the bug Something isn't working label Aug 8, 2024
@ridoo ridoo self-assigned this Aug 8, 2024
@ridoo
Copy link
Collaborator Author

ridoo commented Sep 26, 2024

@gannebamm Here, I did a similar observation as you did on GeoNode/geonode#12616

How to deal with this? My current take on this was it is somehow related to unclean integration the client / localConfig or whatever. Did not find the root cause here. My suggestion would be to wait for upstream feedback and then check.

EDIT: Saw, that you mentioned differences between upload via UI and REST API (and REST API seems to be "broken" here).
@kilichenko-pixida could you please check, if this issue is also true for our version (test by uploading a dataset via curl).

Anyway: you mentioned v4.4.x in the ticket. We are working on v4.3.x at the moment. Do you want us to check current master and v4.4.x branches? On my last check, the actions menu was as you'd expect (incl. Delete action).

@gannebamm
Copy link
Contributor

I wanted to test ahmads work, which is merged and deployed with development demo. There was some strange behaviour with no title but I think this is due to other parts of the code. But for stable it also was not giving the right perms. That was the reason I tested stable (which seems to be on 4.4.x for some reason)

@kilichenko-pixida
Copy link
Contributor

EDIT: Saw, that you mentioned differences between upload via UI and REST API (and REST API seems to be "broken" here). @kilichenko-pixida could you please check, if this issue is also true for our version (test by uploading a dataset via curl).

The delete button is there on our version and it works as expected (after uploading via the API)

@gannebamm
Copy link
Contributor

@kilichenko-pixida could you please try to reproduce on stable.demo.geonode.org

I will test it on our branch again.

@gannebamm
Copy link
Contributor

important info: @kilichenko-pixida do not use the admin account. The admin will get superuser privs and can see and delete the document. It should be uploaded by a registered user. The document uploaded by the registered user should be owned by this user.

In my tests the contact is properly set and the user is set as owner in the metadata. Nonetheless, the user will not be able to delete the ressource or see it if view and download permission defaults are set to private.

@kilichenko-pixida
Copy link
Contributor

@kilichenko-pixida could you please try to reproduce on stable.demo.geonode.org

I will test it on our branch again.

Yes, on the stable demo after aploading via API (api/v2/documents) I can't delete the document I just uploaded via UI

@ridoo
Copy link
Collaborator Author

ridoo commented Oct 2, 2024

@kilichenko-pixida pls check in a local debug session and chase for the root-cause

@kilichenko-pixida
Copy link
Contributor

@gannebamm just checked locally on the letest thuenen_4.x version, with a non-admin user I indeed cannot delete resources after uploading via API, only after UI uploads.

@ridoo
Copy link
Collaborator Author

ridoo commented Oct 29, 2024

just checked locally on the letest thuenen_4.x version, with a non-admin user I indeed cannot delete resources after uploading via API, only after UI uploads.

@gannebamm Then it should be a duplicate of GeoNode/geonode#12616. If fixed, we would have to backport it to v4.3.1.

@kilichenko-pixida
Copy link
Contributor

The upstream PR was merged and issue closed with some small changes, I'll apply those changes to our PR as well s.t. we can close this issue too

@ridoo
Copy link
Collaborator Author

ridoo commented Nov 12, 2024

Here's the referenced PR: GeoNode/geonode#12707

@ridoo
Copy link
Collaborator Author

ridoo commented Nov 19, 2024

@gannebamm upstream issue got closes. This was just related. Feel free to close or move to Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants