Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractArchive dest doesn't work #29

Open
Andrew-Gee opened this issue Jun 27, 2023 · 5 comments
Open

extractArchive dest doesn't work #29

Andrew-Gee opened this issue Jun 27, 2023 · 5 comments
Assignees

Comments

@Andrew-Gee
Copy link

Andrew-Gee commented Jun 27, 2023

This doesn't extract the file anywhere. No error:

extractArchive("somefile.7z", "D:\\tmp\\");

This does extract the file, into local directory.

extractArchive("somefile.7z");
@TheTechsTech
Copy link
Owner

What version you using and other version it was working for you in?

Strange, that's part of basic CI tests. You should do PR, in such creating a test showing issue.

@sergxerj
Copy link
Contributor

sergxerj commented Jul 3, 2023

Missing let in for (command of commands) in https://github.com/TheTechsTech/node-7z-archive/blob/3d280767c0a3a07820635e4f62889bc287e2bc82/src/utility.ts#L83C14-L83C14 making match fail and output null in line 91.

@TheTechsTech
Copy link
Owner

You should do PR on that, not sure that would be valid syntax. "for ( let command of commands)". Anyway, I don't directly use 7z like when I started this project. So fixes directly by me will be slow coming.

That is part of typescript add-on support by another contributor, I don't do typescript.

@TheTechsTech TheTechsTech self-assigned this Jul 3, 2023
sergxerj added a commit to sergxerj/node-7z-archive that referenced this issue Jul 5, 2023
@sergxerj
Copy link
Contributor

sergxerj commented Jul 5, 2023

Fixed it. The bug was also making tests skip silently, except for

  1. SevenZip
  2. createArchive
  3. createSfx
  4. createSfxLinux
  5. createSfxMac
  6. Zip.createSfxWindows
  7. deleteArchive

I'm guessing all the other missing tests were simply silently failing at that point and not reporting at all. . Other symptoms included .tmp dir not being deleted after tests apparently done and all test results not logged to the terminal, only the output.

sergxerj added a commit to sergxerj/node-7z-archive that referenced this issue Jul 5, 2023
Fixes:
- issue TheTechsTech#29 and potential others dealing with output parameter
- test suite now runs all tests
@sergxerj sergxerj mentioned this issue Jul 5, 2023
@TheTechsTech
Copy link
Owner

TheTechsTech commented Jul 5, 2023

@sergxerj seems that PR did the trick, since I'm not actually using now, would have not noticed, I'm only checking if tests pass, not going any further..

updated/registered npm package to 1.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants