-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extractArchive dest doesn't work #29
Comments
What version you using and other version it was working for you in? Strange, that's part of basic CI tests. You should do PR, in such creating a test showing issue. |
Missing |
You should do PR on that, not sure that would be valid syntax. "for ( let command of commands)". Anyway, I don't directly use 7z like when I started this project. So fixes directly by me will be slow coming. That is part of typescript add-on support by another contributor, I don't do typescript. |
Fixed it. The bug was also making tests skip silently, except for
I'm guessing all the other missing tests were simply silently failing at that point and not reporting at all. . Other symptoms included .tmp dir not being deleted after tests apparently done and all test results not logged to the terminal, only the output. |
Fixes: - issue TheTechsTech#29 and potential others dealing with output parameter - test suite now runs all tests
@sergxerj seems that PR did the trick, since I'm not actually using now, would have not noticed, I'm only checking if tests pass, not going any further.. updated/registered npm package to 1.1.5 |
This doesn't extract the file anywhere. No error:
This does extract the file, into local directory.
The text was updated successfully, but these errors were encountered: