Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement app lock for notes section of the app #10

Open
TheGuyDangerous opened this issue Oct 27, 2022 · 9 comments · Fixed by #23
Open

implement app lock for notes section of the app #10

TheGuyDangerous opened this issue Oct 27, 2022 · 9 comments · Fixed by #23
Assignees
Labels
flutter Hacktoberfest eligible for Hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed

Comments

@TheGuyDangerous
Copy link
Owner

No description provided.

@TheGuyDangerous TheGuyDangerous added Hacktoberfest eligible for Hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed flutter labels Oct 27, 2022
@chandansgowda
Copy link
Contributor

Hey @TheGuyDangerous
Can you please explain what has to be done in detail?
Thanks

@TheGuyDangerous
Copy link
Owner Author

Sure !!☺️

@TheGuyDangerous
Copy link
Owner Author

For now , the about_page.dart doesn't contain any settings content .. suitable to its name -

image

So i'm planning to implement some settings content to the page, over time.
One of the settings being an App lock to the notes page -

Here's a sample render of what some of the settings would look like -

So, I'd need a new Option here -

with the title 'App lock' and a dropdown to enable biometric
You can use the
local_auth package for implementing local , on-device authentication of the user.(if possible ,only on notes page if not , we'll discuss)

@chandansgowda
Copy link
Contributor

Thanks @TheGuyDangerous
Assign this to me if its priority is low. Coz I'll be working on it after Wednesday. If it has to be done ASAP, then its okayy.

@TheGuyDangerous
Copy link
Owner Author

Thanks @TheGuyDangerous Assign this to me if its priority is low. Coz I'll be working on it after Wednesday. If it has to be done ASAP, then its okayy.

Take all the time you need ☺️ @chandansgowda !! I've assigned it to you

@chandansgowda
Copy link
Contributor

Hey @TheGuyDangerous
I have setup the UI as required. I have also used shared preferences and local_auth to setup app lock using biometrics. But I'm not able to ask for authentication when a user goes into the notes section. Shall I raise a pull request with what I have done? We can raise a separate issue to add it to notes page later by continuing this issue.

@TheGuyDangerous
Copy link
Owner Author

TheGuyDangerous commented Dec 2, 2022

umm.. yeah .. I looked at it ..
you can send in the pr.. and try to implement it in the meantime :)

Just make sure to push the pr to the dev branch

@chandansgowda
Copy link
Contributor

Hey @TheGuyDangerous
I have raised a PR - #23
Please review.

@TheGuyDangerous TheGuyDangerous linked a pull request Dec 3, 2022 that will close this issue
@TheGuyDangerous
Copy link
Owner Author

awesome @chandansgowda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flutter Hacktoberfest eligible for Hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants