Bugfix/nbs #36
Open
Bugfix/nbs #36
+1,810
−1,790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaticRocket
requested review from
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
|
New warnings found with rstcheck: |
StaticRocket
force-pushed
the
bugfix/nbs
branch
from
180939e
to
10adb6b
Compare
|
New warnings found with rstcheck: |
|
Huh. So it appears that rstcheck doesn't know how to parse the standard substitution lists. |
|
This PR now upgrades rstcheck to a version that can actually parse standard include directives. |
|
New warnings found with rstcheck: |
cshilwant
previously approved these changes
Nov 10, 2024
@StaticRocket Why does it hunts for g++? |
|
It's part of the code block checking. It uses GCC to check if a code block is actually valid C, if it's been tagged as C. Unfortunately most of our code blocks are just snippets with invalid syntax like lines of If you see the commit log, one commit changes this config file key since the newer version of rstcheck doesn't use that key. The new config was picked up by the old workflow so it brings this error up. |
Found a lot of non-breaking spaces in places where they were not needed. Replace them with spaces and fix the resulting whitespace errors. Out of curiosity I was scanning the docs for any non-ascii characters to see if there is anything that could be breaking formatting that standard mechanisms wouldn't catch. Found all of this. Assume it was from the initial import from the processor wiki. Signed-off-by: Randolph Sapp <rs@ti.com>
Use the isonum standard symbol defintions for unicode characters like the registered sign. Signed-off-by: Randolph Sapp <rs@ti.com>
Use isonum standard symbol definitions for the micro symbol. Signed-off-by: Randolph Sapp <rs@ti.com>
Use standard I2C notation instead of using the unicode power of 2 symbol. Signed-off-by: Randolph Sapp <rs@ti.com>
Use isonum standard symbol definitions for the degree sign. Signed-off-by: Randolph Sapp <rs@ti.com>
Use ascii vertical bar instead of the unicode broken bar symbol. Signed-off-by: Randolph Sapp <rs@ti.com>
Based on the rest of this code snippet, this character should have never been here. Signed-off-by: Randolph Sapp <rs@ti.com>
Fix invalid characters in csv table. An old jira ticket is using unusual characters. Signed-off-by: Randolph Sapp <rs@ti.com>
Now that this is fully containerized, bump all requirements to the latest stable release. This includes a massive rework of rstcheck that makes it capable of parsing include and a few other sphinx directives. Signed-off-by: Randolph Sapp <rs@ti.com>
The config for rstcheck changed slightly, it expects ignore_language to be ignore_languages now. Signed-off-by: Randolph Sapp <rs@ti.com>
StaticRocket
force-pushed
the
bugfix/nbs
branch
from
8c68664
to
329b49c
Compare
|
New warnings found with rstcheck: |
|
You know what, let me split this PR. Package upgrades should be independent of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various style issues and odd character usage that may affect rst parsers.