Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(component-owners): try using component-owners #32

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StaticRocket
Copy link
Member

Try using component-owners instead of CODEOWNERS since the latter requires all listed users have write permission to the repo.

This only requires that they were a previous contributor.

Closes #8

Try using component-owners instead of CODEOWNERS since the latter
requires all listed users have write permission to the repo.

This only requires that they were a previous contributor.

Signed-off-by: Randolph Sapp <rs@ti.com>
@cshilwant
Copy link
Member

cshilwant commented Nov 2, 2024

++ @DhruvaG2000 , @praneethbajjuri , @uditkumarti , @aniket-l

IMO, This looks better!
We can use this approach until GitHub resolves - https://github.com/orgs/community/discussions/23042#discussioncomment-3238768

@StaticRocket I'm still thinking to have CODEOWNERS file with following content,

* <list of code owners>

Reason - With component-owners, since reviewers won't have write access they would still need folks with more than write privileges to integrate the PR

(For instance - for any change in /source/buildroot/, the reviewers under ./ won't be notified)
So, CODEOWNERS file can be used for the same.

@StaticRocket
Copy link
Member Author

That's fair. Assuming the two don't conflict I think it would make sense to let CODEOWNERS pull in the maintainers and let this tack on the granular component owners.

I'll work with @praneethbajjuri and try to track down some specific component owners. The code owners file you added should be a good catch all in the meantime.

Consider this PR a draft for now.

@StaticRocket StaticRocket marked this pull request as draft November 2, 2024 05:30
@cshilwant
Copy link
Member

@StaticRocket Sounds like a plan. I have updated #31 to just include maintainers for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a CODEOWNERS file to auto assign reviewers
2 participants