Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: 修复非超管查询全部业务历史任务报错(fixed #1631) #1742

Conversation

neko12583
Copy link
Collaborator

PR

CheckList(PR Assigners)

确认已完成以下操作:

  • 已将分支与当前合入分支同步
  • 已在关联 Issue 中补充「功能自测」部分内容
  • 已更新关联 Issue 的状态 backlog -> todo -> for test -> tested(需通过测试同学测试) -> done
  • 将 PR 添加上 pr/reviewable

CheckList(PR Reviewers)

确认已完成以下操作:

  • 检查关联 Issue 「功能自测」部分内容
  • 必要时打回 pr/reviewable,要求重新修改
  • 及时 Approve

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v2.4.1-dev@51b0e26). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             v2.4.1-dev    #1742   +/-   ##
=============================================
  Coverage              ?   73.62%           
=============================================
  Files                 ?      393           
  Lines                 ?    26458           
  Branches              ?        0           
=============================================
  Hits                  ?    19481           
  Misses                ?     6977           
  Partials              ?        0           

@ZhuoZhuoCrayon
Copy link
Member

ZhuoZhuoCrayon commented Aug 15, 2023

Traceback (most recent call last):
File "/venv/lib/python3.6/site-packages/rest_framework/views.py", line 506, in dispatch
response = handler(request, *args, **kwargs)
File "/app/apps/node_man/views/job.py", line 89, in job_list
return Response(JobHandler().list(self.validated_data, get_request_username()))
File "/app/apps/node_man/handlers/job.py", line 189, in list
[Q(bk_biz_scope__contains=bk_biz_id) for bk_biz_id in search_biz_ids],
TypeError: 'NoneType' object is not iterable

Copy link
Member

@ZhuoZhuoCrayon ZhuoZhuoCrayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZhuoZhuoCrayon ZhuoZhuoCrayon merged commit 29f30e9 into TencentBlueKing:v2.4.1-dev Aug 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants