Skip to content

fix: project-manager itsm migrate 幂等 (#3614) #3817

fix: project-manager itsm migrate 幂等 (#3614)

fix: project-manager itsm migrate 幂等 (#3614) #3817

Triggered via push November 27, 2024 06:49
Status Failure
Total duration 7m 9s
Artifacts

lint.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

14 errors and 10 warnings
bcs-cluster-resources: bcs-services/cluster-resources/pkg/action/view/view.go#L434
S1032: should use sort.Strings(...) instead of sort.Sort(sort.StringSlice(...)) (gosimple)
bcs-cluster-resources: bcs-services/cluster-resources/pkg/action/view/view.go#L449
S1032: should use sort.Strings(...) instead of sort.Sort(sort.StringSlice(...)) (gosimple)
bcs-cluster-resources: bcs-services/cluster-resources/pkg/action/view/view.go#L464
S1032: should use sort.Strings(...) instead of sort.Sort(sort.StringSlice(...)) (gosimple)
bcs-cluster-resources
issues found
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/remote/nodeman/client.go#L1
: # github.com/Tencent/bk-bcs/bcs-services/bcs-cluster-manager/internal/remote/nodeman [github.com/Tencent/bk-bcs/bcs-services/bcs-cluster-manager/internal/remote/nodeman.test]
bcs-cluster-manager
not enough arguments in call to cli.CloudList
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/cloudprovider/aws/tasks/import_cluster.go#L136
Error return value of `(github.com/Tencent/bk-bcs/bcs-services/bcs-cluster-manager/internal/store.ClusterManagerModel).UpdateCluster` is not checked (errcheck)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/cloudprovider/eop/tasks/create_cluster.go#L822
Function 'checkClusterNodesStatus' is too long (130 > 90) (funlen)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/cloudprovider/qcloud-public/business/tke.go#L927
Function 'CheckClusterAllInstanceStatus' is too long (98 > 90) (funlen)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/cloudprovider/aws/tasks/create_node_group.go#L316
Function 'CheckCloudNodeGroupStatusTask' is too long (110 > 90) (funlen)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/cloudprovider/qcloud-public/tasks/updateDesiredNodes.go#L36
Function 'ApplyInstanceMachinesTask' is too long (120 > 90) (funlen)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/actions/cluster/create.go#L440
Function 'Handle' is too long (96 > 90) (funlen)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/store/machinery/task.go#L22
File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/Tencent/bk-bcs/bcs-services/bcs-cluster-manager) (gci)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/store/machinery/task.go#L26
File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/Tencent/bk-bcs/bcs-services/bcs-cluster-manager) (gci)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/store/types/machinery_task.go#L13
package-comments: should have a package comment (revive)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/store/types/machinery_task.go#L36
exported: exported type Task should have comment or be unexported (revive)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/store/machinery/task.go#L13
package-comments: should have a package comment (revive)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/actions/health/clean_history_data.go#L28
exported: exported const DataTask should have comment (or a comment on this block) or be unexported (revive)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/remote/cmdb/types.go#L53
exported: exported const FieldHostIP should have comment (or a comment on this block) or be unexported (revive)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/remote/cmdb/types.go#L61
exported: comment on exported const FieldAssetId should be of the form "FieldAssetId ..." (revive)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/cloudprovider/eop/api/constant.go#L13
package-comments: should have a package comment (revive)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/cloudprovider/eop/tasks/create_cluster.go#L13
package-comments: should have a package comment (revive)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/cloudprovider/aws/api/as.go#L13
package-comments: should have a package comment (revive)
bcs-cluster-manager: bcs-services/bcs-cluster-manager/internal/cloudprovider/eop/cloudmgr.go#L13
package-comments: should have a package comment (revive)