Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add effect-form-adapter #718

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

jessekelly881
Copy link

@jessekelly881 jessekelly881 commented May 24, 2024

Copy link

nx-cloud bot commented May 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c3b60b4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3

Sent with 💌 from NxCloud.

@crutchcorn
Copy link
Member

I love this!! Thank you so much for making such a big contribution as your first time contributing!

Let's add docs + examples, then get this one merged in!

@crutchcorn
Copy link
Member

Hey @jessekelly881 - wanted to check in on this. It's still marked as a draft PR, but otherwise LGTM. Is there anything we're waiting on prior to a review/merge?

@jessekelly881
Copy link
Author

jessekelly881 commented Jun 3, 2024

Hey @crutchcorn! At the moment it's missing an example for angular(I haven't used angular in a very long time and I am having some issues getting the examples running on my local for some reason.. :( ), a proper solution to the typeof schema === "function" issue I mentioned (the solution I have at the moment is incorrect sense function() {} is a "constructible" in js), I want to extend the createValidator api a little bit(there are other ways to create a validator that make sense) and probably docs but I'm not yet sure where the docs need updated yet.

@crutchcorn
Copy link
Member

Sounds good! Let me know if there's anything questions I can help answer with the local setup or anything of the nature ☺️

Keep up the great work!

@jessekelly881
Copy link
Author

jessekelly881 commented Jun 3, 2024

I'm currently running into this error with the angular examples(all of them). But the suggested solution of setting "preserveSymlinks" to true doesn't seem to work. angular/angular#54147

@jessekelly881 jessekelly881 marked this pull request as ready for review June 4, 2024 10:10
@jessekelly881 jessekelly881 changed the title add effect-form-adaptor add effect-form-adapter Jun 4, 2024
@jessekelly881
Copy link
Author

@crutchcorn Wanna have another look? :)

@crutchcorn crutchcorn mentioned this pull request Jun 27, 2024
5 tasks
@crutchcorn crutchcorn mentioned this pull request Jul 6, 2024
11 tasks
@izakfilmalter
Copy link

Any updates on this, would love to see this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants