-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add effect-form-adapter #718
base: main
Are you sure you want to change the base?
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c3b60b4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
I love this!! Thank you so much for making such a big contribution as your first time contributing! Let's add docs + examples, then get this one merged in! |
77a762d
to
982fc83
Compare
Hey @jessekelly881 - wanted to check in on this. It's still marked as a draft PR, but otherwise LGTM. Is there anything we're waiting on prior to a review/merge? |
Hey @crutchcorn! At the moment it's missing an example for angular(I haven't used angular in a very long time and I am having some issues getting the examples running on my local for some reason.. :( ), a proper solution to the |
Sounds good! Let me know if there's anything questions I can help answer with the local setup or anything of the nature Keep up the great work! |
I'm currently running into this error with the angular examples(all of them). But the suggested solution of setting "preserveSymlinks" to true doesn't seem to work. angular/angular#54147 |
@crutchcorn Wanna have another look? :) |
Any updates on this, would love to see this merged. |
Adapted from
zod-form-adapter
.https://github.com/Effect-TS/effect/tree/main/packages/schema