Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test warning in logging module (accidently pushed to master in 92411c2) #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test warning in logging module (accidently pushed to master in 92411c2) #148

wants to merge 1 commit into from

Conversation

SiggyF
Copy link
Contributor

@SiggyF SiggyF commented Mar 21, 2024

  • test that accessing .log does not give warnings (issue in pandas)
  • test that accessing .log and .logbook give expected results for both log_entry_v0 and log_entry_v1

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Pietervanhalem
Pietervanhalem requested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@Pietervanhalem Pietervanhalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pietervanhalem Pietervanhalem Pietervanhalem requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SiggyF @Pietervanhalem